Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Troubleshooting via nested tabbed content #7529

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cwarnermm
Copy link
Member

@cwarnermm cwarnermm commented Oct 31, 2024

Outstanding:

  • Remove the grey background fill colour for indented content (unnecessary & adding visual noise that's even more obvious via tabbed content).
  • Add animated GIFs for Mattermost-specific flows only
  • Consider updating CSS to show nested logic

@cwarnermm cwarnermm added the Work In Progress Not yet ready for review label Oct 31, 2024
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 5b16ce2

@cwarnermm cwarnermm changed the title First experiment nesting tabs Notification Troubleshooting via nested tabbed content Nov 1, 2024
@cwarnermm cwarnermm removed the Work In Progress Not yet ready for review label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Newest code from mattermost has been published to preview environment for Git SHA ae7317e


.. tab:: Mobile

Ensure that your Mattermost mobile preferences have notifications enabled.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't these belong in the section above Check your Mattermost preferences? I think these are not "client settings" but Mattermost preferences when the client is Mobile.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhijit-singh - I asked myself the very same question and decided to simplify the instructions and story we're trying to tell with this structure. Very open to further discussion with the UX on this if you feel that this approach will introduce confusion.


If you prefer to use Mattermost in a web browser, you must grant notification permissions for Mattermost in the web browser. If you don't, the web browser can block you from receiving Mattermost notifications. Select the **Chrome**, **Edge**, **Firefox**, or **Safari** tab based on your preferred web browser:

.. tab:: Chrome

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add these browser (Chrome, Edge...) tabs within the <blockquote> tag just above them? It makes their nested nature much clearer visually. I was trying it out in the inspect element and this is what it looked like -

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I'll need CSS assistance to achieve that outcome.


Also ensure that macOS’ **Focus mode** is turned off.

.. tab:: Windows

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make 'Windows' the first tab since I think that's the OS a majority of our users would be on.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, everything is alphabetically ordered. Open to reordering based on popularity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants