Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-7522: Create Channels page needs animated GIFs for mobile app workflows #7523

Merged
merged 2 commits into from
Oct 31, 2024
Merged

DOC-7522: Create Channels page needs animated GIFs for mobile app workflows #7523

merged 2 commits into from
Oct 31, 2024

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Oct 31, 2024

Summary

This PR adds visual workflows for the Mattermost mobile app tabs on the Create channels page

Ticket Link

Fixes #7522

  • This PR follows Mattermost Contributing Guidelines.

@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 31, 2024

@cwarnermm Please review and suggest changes, if any. Thanks.

@lindy65 Please add this to my queue for QA Testing once the reviews are complete. Thank you.

@lindy65 lindy65 added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 31, 2024
@lindy65
Copy link
Contributor

lindy65 commented Oct 31, 2024

Assigned to you for QA review @Rutam21

@github-actions GitHub Actions
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA c3d2dbf

@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 31, 2024

The changes are tested in the preview environment and they reflect properly.

  • The CreateNew Channel sub-section has now 2 workflow images for visual learners.
  • The Open a Direct Message sub-section also has 2 workflow images.

Please refer to the screenshots below as a confirmation.

Current Docs Page [Create Channels]

Screenshot 2024-10-31 140712

Preview Environment Page

Screenshot 2024-10-31 140738

[Awaiting final review from @cwarnermm ]

cc: @lindy65

@lindy65
Copy link
Contributor

lindy65 commented Oct 31, 2024

Thanks for testing @Rutam21 - counted towards Hacktoberfest

cwarnermm
cwarnermm approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Rutam21!!

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request QA-done QA review is complete labels Oct 31, 2024
@cwarnermm cwarnermm merged commit e0f5e43 into mattermost:master Oct 31, 2024
6 checks passed
@Rutam21 Rutam21 deleted the DOC-7522 branch October 31, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories QA-done QA review is complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Channels page needs animated GIFs for mobile app workflows
4 participants
@Rutam21 @mattermost-build @lindy65 @cwarnermm