Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enterprise BYOK #6845

Merged
merged 11 commits into from
Jan 12, 2024
Merged

Enterprise BYOK #6845

merged 11 commits into from
Jan 12, 2024

Conversation

stafot
Copy link
Contributor

@stafot stafot commented Dec 15, 2023

Summary

Enterprise BYOK

Ticket Link

https://mattermost.atlassian.net/browse/CLD-6817

@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA 74727ec

@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA 13c883e

@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA e9d85fb

@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA 514edd7

@stafot stafot force-pushed the CLD-6817 branch 2 times, most recently from 9f6f35e to eda0a05 Compare December 18, 2023 08:01
@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA 9f6f35e

@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA eda0a05

@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA 397eff9

@stafot
Enterprise BYOK
d93fdb5 
Signed-off-by: Stavros Foteinopoulos <[email protected]>
@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA d93fdb5

@stafot stafot marked this pull request as ready for review December 19, 2023 12:27
@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA 0939e47

cwarnermm
cwarnermm reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stafot - I've provided editorial feedback inline. Please review technically to ensure that my proposed edits haven't changed the intended meaning by mistake. Happy to iterate on phrasing in more detail if needed.

source/guides/cloud-workspace-management.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
@cwarnermm cwarnermm added 1: Dev Review Requires review by a core commiter 1: PM Review Requires review by a product manager 2: Editor Review Requires review by an editor 2. SME Review labels Dec 20, 2023
@stafot @cwarnermm
Apply suggestions from code review
20acf16 
Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA 20acf16

@github-actions GitHub Actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 4116e75

@cwarnermm cwarnermm self-requested a review December 20, 2023 18:46
@github-actions GitHub Actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 2ec0ba0

@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA 0e7ee48

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Newest code from stafot has been published to preview environment for Git SHA ddeb0f1

@cwarnermm cwarnermm removed the 2: Editor Review Requires review by an editor label Jan 9, 2024
spirosoik
spirosoik approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@spirosoik spirosoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor comments

source/_static/badges/ent-cloud-dedicated.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
stylianosrigas
stylianosrigas reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@stylianosrigas stylianosrigas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit suggestions

source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
source/manage/cloud-byok.rst Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Newest code from stafot has been published to preview environment for Git SHA f354c47

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Newest code from stafot has been published to preview environment for Git SHA 6f51570

@stafot
more review fixes
6af4293 
Signed-off-by: Stavros Foteinopoulos <[email protected]>
@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA 6af4293

@amyblais amyblais added this to the v9.4.0 milestone Jan 11, 2024
@amyblais amyblais removed the 1: Dev Review Requires review by a core commiter label Jan 11, 2024
@github-actions GitHub Actions
Copy link

Newest code from stafot has been published to preview environment for Git SHA e88702c

@stafot stafot merged commit 89775dc into master Jan 12, 2024
4 checks passed
@stafot stafot deleted the CLD-6817 branch January 12, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

@iyampaul iyampaul iyampaul approved these changes

@spirosoik spirosoik spirosoik approved these changes

@nab-77 nab-77 Awaiting requested review from nab-77

@stylianosrigas stylianosrigas Awaiting requested review from stylianosrigas

Assignees
No one assigned
Labels
1: PM Review Requires review by a product manager 2. SME Review
Projects
None yet
Milestone
v9.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@stafot @spirosoik @iyampaul @stylianosrigas @cwarnermm @amyblais