Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Changing Rate Limit Settings #6713

Merged
merged 12 commits into from
Oct 20, 2023
Merged

Clarify Changing Rate Limit Settings #6713

merged 12 commits into from
Oct 20, 2023

Conversation

TomerPacific
Copy link
Contributor

Summary

Adding explanation of increasing/lowering query/burst/memory in rate limit section.

Ticket Link

Fixes #6591

@mattermost-build
Copy link
Contributor

Hello @TomerPacific,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@TomerPacific TomerPacific mentioned this pull request Oct 16, 2023
Closed
@cwarnermm cwarnermm self-requested a review October 16, 2023 19:28
@cwarnermm cwarnermm added the 2: Editor Review Requires review by an editor label Oct 16, 2023
@cwarnermm cwarnermm added 1: PM Review Requires review by a product manager preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 16, 2023
@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 31a7afd

1 similar comment
@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 31a7afd

cwarnermm
cwarnermm requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @TomerPacific. I've provided editorial feedback inline.

source/configure/rate-limiting-configuration-settings.rst Outdated Show resolved Hide resolved
source/configure/rate-limiting-configuration-settings.rst Outdated Show resolved Hide resolved
source/configure/rate-limiting-configuration-settings.rst Outdated Show resolved Hide resolved
source/configure/rate-limiting-configuration-settings.rst Outdated Show resolved Hide resolved
@cwarnermm cwarnermm added the Awaiting Submitter Action Blocked on the author label Oct 17, 2023
@cwarnermm cwarnermm self-requested a review October 17, 2023 13:06
@cwarnermm cwarnermm removed the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Oct 17, 2023
@TomerPacific
Copy link
Contributor Author

@cwarnermm - Performed all requested changes.

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed Awaiting Submitter Action Blocked on the author labels Oct 17, 2023
@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 5d1a6db

@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 4b461bd

@cwarnermm
Copy link
Member

@TomerPacific:

When you look at the latest generated preview of the docs, you'll see that the updated content doesn't display. That's because it's been added to the code section that drives search results, and not to the table content a little further down the page.

The final step of this PR is to move these details to the tables themselves (specifically to the left-hand description column). I'm happy to help with this step, or you're welcome to apply the needed changes yourself in this PR if you're open to it.

@cwarnermm cwarnermm added Awaiting Submitter Action Blocked on the author and removed 1: PM Review Requires review by a product manager labels Oct 18, 2023
@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 9c3250c

@TomerPacific
Copy link
Contributor Author

@cwarnermm - I moved the explanations to be inside the table.
Wanted to ask how I can trigger the deployment of the branch to a preview environment?
I've gotten stuck setting up my local environment and I posted about it a few days ago in the Contributors channel.

@cwarnermm
Copy link
Member

Thanks, @TomerPacific! I appreciate you being so willing to finalize this docs PR!

Generated docs previews are triggered by the preview-environment label; however, only users with appropriate permissions (typically Mattermost staff) are able to add/remove this label from PRs contributed by community members.

@cwarnermm cwarnermm removed the Awaiting Submitter Action Blocked on the author label Oct 18, 2023
@TomerPacific
Copy link
Contributor Author

TomerPacific commented Oct 20, 2023 •
edited
Loading

@cwarnermm - Is there any more work required here?

@cwarnermm
Copy link
Member

This docs PR will go through editorial review next before being merged. I appreciate your patience!

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 20, 2023
@cwarnermm cwarnermm merged commit 61b2f53 into mattermost:master Oct 20, 2023
4 checks passed
@TomerPacific TomerPacific deleted the feature/clarify-changing-rate-limit-settings branch October 20, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwarnermm cwarnermm cwarnermm approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor Hacktoberfest null
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help Wanted: Clarify the impact of changing rate limit settings
3 participants
@TomerPacific @mattermost-build @cwarnermm