-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify use of read replicas #6588
Conversation
The docs suggest that reads are evenly distributed between the master DB and the read replica DBs. Based on both the server code and the observed behaviour, I do not believe that is the case - I believe that (if any read replicas are available) read queries are distributed among the read replicas only. This is a useful distinction to keep in mind for site admins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original text is technically correct. While it's true that 99% of times, read requests are sent to the read replicas, there are cases where they aren't. If you want to change the text to reflect this, we can do it. Otherwise we can leave it as is.
Yes - I think there's a big difference between "Mattermost distributes read requests across all databases", and "Mattermost distributes almost all read requests across the read replicas only". Would indeed like to see an update... Are you asking me to propose different wording? |
@grubbins - We'd welcome your docs contribution with updated, clarified wording if you're open to it. |
OK - please see what you think of my latest wording. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, @grubbins!
Oops - I think the markdown requires a linebreak before the bullet points. The html currently up on the docs page has them as inline asterisks. Could you insert the linebreak @cwarnermm ? Or do you need me to open a new PR with it? |
I'm happy to update the formatting, @grubbins! |
Fixed via #6627 |
The docs suggest that reads are evenly distributed between the master DB and the read replica DBs. Based on both the server code and the observed behaviour, I do not believe that is the case - I believe that (if any read replicas are available) read queries are distributed among the read replicas only. This is a useful distinction to keep in mind for site admins.