Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update desktop-app.rst #6569

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Update desktop-app.rst #6569

merged 7 commits into from
Aug 28, 2023

Conversation

gary-sixgen
Copy link
Contributor

Summary

Ticket Link

@mattermost-build
Copy link
Contributor

Hello @gary-sixgen,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@gary-sixgen
Copy link
Contributor Author

/check-cla

@cwarnermm cwarnermm added the 1: Dev Review Requires review by a core commiter label Aug 3, 2023
@cwarnermm cwarnermm self-requested a review August 3, 2023 17:19
@cwarnermm cwarnermm added the 2: Editor Review Requires review by an editor label Aug 3, 2023
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @gary-sixgen, quick typo I found but otherwise LGTM.

source/deploy/desktop-app.rst Outdated Show resolved Hide resolved
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gary-sixgen!

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Aug 28, 2023
@cwarnermm cwarnermm merged commit b516e88 into mattermost:master Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants