Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker compose command #6457

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix: docker compose command #6457

merged 2 commits into from
Jul 24, 2023

Conversation

matinzd
Copy link
Contributor

@matinzd matinzd commented Jun 12, 2023

Summary

Fix docker compose command

Ticket Link

N/A

@mattermost-build
Copy link
Contributor

Hello @matinzd,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@matinzd
Copy link
Contributor Author

matinzd commented Jun 12, 2023

/check-cla

@cwarnermm cwarnermm requested a review from nab-77 June 13, 2023 13:10
@cwarnermm cwarnermm added the 1: PM Review Requires review by a product manager label Jun 13, 2023
@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Copy link
Member

@coltoneshaw coltoneshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes would work on all machines, if I understand correctly. docker compose is the new version of docker-compose. The only hurdle is if someone hasn't updated their docker package recently they might not be able to run this. But they can do a quick google search.

@matinzd
Copy link
Contributor Author

matinzd commented Jul 14, 2023

These changes would work on all machines, if I understand correctly. docker compose is the new version of docker-compose. The only hurdle is if someone hasn't updated their docker package recently they might not be able to run this. But they can do a quick google search.

Yeah, but it's better to keep the document updated to the latest version of docker compose plugin.

migrate to new docker compose plugin
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @matinzd!

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager 2. SME Review labels Jul 24, 2023
@cwarnermm cwarnermm removed the request for review from nab-77 July 24, 2023 13:19
@cwarnermm cwarnermm merged commit fb3fc53 into mattermost:master Jul 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants