Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade @electron/rebuild from 3.6.0 to 3.7.0 #3163

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

mm-prodsec-bot
Copy link
Contributor

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • e2e/package.json
    • e2e/package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 631/1000
Why? Proof of Concept exploit, Has a fix available, CVSS 6.2
Missing Release of Resource after Effective Lifetime
SNYK-JS-INFLIGHT-6095116
No Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: @electron/rebuild The new version differs by 26 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@mm-cloud-bot
Copy link

@mm-prodsec-bot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

@devinbinnie devinbinnie added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 9, 2024
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me.
@yasserfaraazkhan Can you run the E2E tests for each OS and make sure everything still rebuilds correctly?

@yasserfaraazkhan yasserfaraazkhan added the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 10, 2024
Copy link

Here are the test results below:

Test Summary for Linux on commit bd533d0

New failed tests found on Linux:

  • menu/view MM-T816 Toggle Full Screen in the Menu Bar

Test Summary for macOS on commit bd533d0

All stable tests passed on macOS.

@github-actions github-actions bot removed the Run Desktop E2E Tests This label will trigger the workflow that runs e2e automation tests label Oct 10, 2024
Copy link
Contributor

@yasserfaraazkhan yasserfaraazkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devinbinnie this is good to merge

@devinbinnie devinbinnie merged commit 4ac0d68 into master Oct 11, 2024
44 of 47 checks passed
@devinbinnie devinbinnie deleted the snyk-fix-c70f4c10c27b07ddd5a6a5018df835f5 branch October 11, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester do-not-merge/release-note-label-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants