Added support for notification with server version greater than 9 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-confluence-fork into notification_setup
…n-confluence-fork into notification_setup
…ost-plugin-confluence into notification_setup
wiggin77
reviewed
Feb 4, 2025
wiggin77
reviewed
Feb 4, 2025
wiggin77
reviewed
Feb 4, 2025
wiggin77
reviewed
Feb 4, 2025
|
@wiggin77 Fixed the comments |
wiggin77
reviewed
Feb 5, 2025
wiggin77
reviewed
Feb 5, 2025
| var previousStartToken html.Token | ||
|
|
||
| for { | ||
| tt := domDoc.Next() |
There was a problem hiding this comment.
Since the only way out of this loop is when a html.ErrorToken is received, are we guaranteed to get this error at some point? There is no EOF token?
There was a problem hiding this comment.
Yes, html.ErrorToken is guaranteed.
html.ErrorToken is used to indicate an EOF
wiggin77
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for notification with server version greater than 9
Screenshots