Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

refactor: improve zk stack block explorer guide pt1 #949

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

zk-Lumi
Copy link
Contributor

@zk-Lumi zk-Lumi commented Feb 22, 2024

What 💻

  • Remade guide for using block explorer
  • Removed inaccurate wording for using block explorer
  • Improved wording for using block explorer
  • Split block explorer part into 2 sections -> 1) via docker 2) locally

Why ✋

  • Part of the guide was inaccurate
  • Also this section was quite confusing on how to use block explorer

@zk-Lumi zk-Lumi requested review from a team as code owners February 22, 2024 18:17
Copy link

github-actions bot commented Feb 22, 2024

Visit the preview URL for this PR (updated for commit f4a2e43):

https://staging-zksync-web-era-docs--pr949-zk-lumi-patch-1-1mmm0bpw.web.app

(expires Wed, 13 Mar 2024 07:14:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f408c7165e11221d785cc3915b60f2a4a4f277f9

@zk-Lumi
Copy link
Contributor Author

zk-Lumi commented Feb 22, 2024

Part 1 (this PR) - This is to update the section on block explorer running locally, wording, and to remove inaccurate description.

Part 2 (next PR) - @githubdoramon will help update the section on block explorer running in docker in coming days.

Copy link
Contributor

@githubdoramon githubdoramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some small changed

docs/zk-stack/running-a-hyperchain/locally.md Outdated Show resolved Hide resolved
docs/zk-stack/running-a-hyperchain/locally.md Outdated Show resolved Hide resolved
docs/zk-stack/running-a-hyperchain/locally.md Outdated Show resolved Hide resolved
docs/zk-stack/running-a-hyperchain/locally.md Outdated Show resolved Hide resolved
@zk-Lumi zk-Lumi requested a review from githubdoramon March 6, 2024 07:15
@githubdoramon githubdoramon merged commit e680d8f into main Mar 6, 2024
7 checks passed
@githubdoramon githubdoramon deleted the zk-Lumi-patch-1 branch March 6, 2024 09:28
Copy link

github-actions bot commented Mar 6, 2024

🎉 This PR is included in version 1.34.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants