feat: use a single id for account id #309
Open
+70
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having a known salt which is used to derive the create2 salt, and a static id which is used to derive an account id, use the same hashed id for both. This avoids the problem of having contention over account ids, but removes the ability for a deployer to select a specific account id. (an account mapping of msg.sender to account id would have the same effect)
cpb8010
added
enhancement
cpb8010
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the same hashed id for both the create2 salt and the static id which is used to derive an account id.
This avoids the problem of having contention over account ids, but removes the ability for a deployer to select a specific account id. (an account mapping of msg.sender to account id to address would have the same effect, but now we only hash once or off-chain)
Additional context
Instead of subtly breaking backwards comparability by changing the account ids, this changes the interface so it's clear that the ids work differently now. The SDK previously expected to be able to read-back the account id to check if an account was already deployed, so it (and other SDK users) will need to be updated from this breaking change.