Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(consensus): Set p2p syncing as default #3255

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

feat(consensus): Set p2p syncing as default #3255

wants to merge 12 commits into from

Conversation

brunoffranca
Copy link
Member

@brunoffranca brunoffranca commented Nov 11, 2024 •
edited
Loading

What ❔

Removes the option to start an external node without consensus config. So it effectively forces nodes to use p2p syncing.

Why ❔

We want to deprecate JSON-RPC syncing soon.

@brunoffranca brunoffranca changed the title feat: Set p2p syncing as default feat(consensus): Set p2p syncing as default Nov 13, 2024
@brunoffranca brunoffranca marked this pull request as ready for review November 13, 2024 18:57
@brunoffranca brunoffranca requested a review from a team as a code owner November 13, 2024 18:57
@brunoffranca brunoffranca marked this pull request as draft November 15, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

@pompon0 pompon0 Awaiting requested review from pompon0

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brunoffranca