feat(zk_toolbox): Make chain create independent from ecosystem #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/zksync-era into matias/separate-chain-create
matias-gonz
changed the base branch from
main
to
matias/refactor-chain-commands
…bs/zksync-era into matias/separate-chain-create
matias-gonz
changed the base branch from
matias/refactor-chain-commands
to
main
…bs/zksync-era into matias/separate-chain-create
matias-gonz
changed the base branch from
main
to
matias/refactor-chain-commands
matias-gonz
changed the title
matias-gonz
requested review from
yorik,
alexandrst88,
artmakh and
hatemosphere
and removed request for
a team
…bs/zksync-era into matias/separate-chain-create
Deniallugo
reviewed
Nov 11, 2024
| } else { | ||
| (L2ChainId::from(args.chain_id), None) | ||
| }; | ||
| let internal_id = ecosystem_config.list_of_chains().len() as u32; | ||
|
|
||
| let internal_id = args.number_of_chains + 1; |
There was a problem hiding this comment.
it's always zero in a case we don't have ecosystem config
Deniallugo
reviewed
Nov 11, 2024
…bs/zksync-era into matias/separate-chain-create
…bs/zksync-era into matias/separate-chain-create
Deniallugo
reviewed
Nov 14, 2024
Comment on lines
+111
to
+115
| let l1_network = l1_network.unwrap_or_else(|| { | ||
| self.l1_network.unwrap_or_else(|| { | ||
| PromptSelect::new(MSG_L1_NETWORK_PROMPT, L1Network::iter()).ask() | ||
| }) | ||
| }); |
There was a problem hiding this comment.
Looks a bit odd. Why do we have two places for l1 network?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.