-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zksync_cli): Health checkpoint improvements #3193
Open
manuelmauro
wants to merge
55
commits into
main
Choose a base branch
from
manuel-add-more-components-to-healthcheck
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
8dd58dc
feat: add dummy node version heathcheck
manuelmauro 98167a1
feat: add version information to healthcheck
manuelmauro d08ecae
refactor: simplify static health check
manuelmauro a058388
feat: add last migration to system_dal
manuelmauro a5f571b
feat: add database healthcheck
manuelmauro a5db49a
feat: add more information to database heathcheck
manuelmauro b57027c
style: format code
manuelmauro 5d23bd6
chore: prepare sqlx queries
manuelmauro 959542b
fix: remove outdated query file
manuelmauro 28ecc96
feat: improve bytes encoding in healthcheck
manuelmauro 3d7e82c
Merge branch 'main' into manuel-add-more-components-to-healthcheck
manuelmauro de3a5e1
feat: add dummy health check tasks for state keeper and eth sender
manuelmauro 582754b
fix: do not unwrap
manuelmauro 1b8e50e
feat: retrieve failed L1 transactions and next operator nonce
manuelmauro 68210aa
feat: add information on last saved/mined batches to healthcheck
manuelmauro 2fc3da9
feat: get last miniblock number from DB
manuelmauro 098e54f
feat: add protocol version information to healthcheck
manuelmauro 4cbb890
feat: add last processed L1 batch to health check
manuelmauro f60e3a9
refactor: use SELECT MAX instead of ORDER BY
manuelmauro 927cddb
refactor: rename LastBatchIndex to BatchNumbers
manuelmauro 80db2ce
fix: revert code committed by mistake
manuelmauro 2c9ca8d
feat: add config parameters for healthcheck polling intervals
manuelmauro 98f8d72
fix: fix house keeper config from env test
manuelmauro 988b957
fix: fix house keeper config parameters naming in unit test
manuelmauro 293484d
fix: use u64 for failed_l1_txns
manuelmauro 3ad3fd2
fix: return u64 in get_number_of_failed_transactions
manuelmauro b31233b
feat: use connection_tagged for better code instumentation
manuelmauro 5396e5a
feat: add reactive health check to state keeper
manuelmauro f51785c
fix: update state keeper health at the right moment
manuelmauro bb5acfc
refactor: use ORDER BY to query last database migration
manuelmauro fd35543
feat: add reactive health check to eth sender
manuelmauro 416ea50
style: clippy
manuelmauro d0ac511
Merge branch 'main' into manuel-add-more-components-to-healthcheck
manuelmauro 8d4c176
style: move field before reserved ones
manuelmauro eb2fb68
refactor: rename PostgresMetricsLayer to PostgresLayer
manuelmauro 80986e4
refactor: rename postgres_metrics_layer to postgres_layer
manuelmauro 9bffd99
refactor: rename module postgres_layer to postgres
manuelmauro 5e235b1
refactor: move database health check task to postgres layer
manuelmauro 884b864
feat: implement Serialize and Deserialize directly on AggregatedActio…
manuelmauro c701399
refactor: make DatabaseHealthTask fields private
manuelmauro 53cca2f
refactor: remove redundant health status updates
manuelmauro fe339c2
Merge branch 'main' into manuel-add-more-components-to-healthcheck
manuelmauro 9fe98d2
feat: make health mod private
manuelmauro 36ad7c5
refactor: remove StateKeeperTask constructor
manuelmauro 1585d5d
refactor: use getter for health updater
manuelmauro f9e2ebf
refactor: clippy
manuelmauro 26aa824
feat: add git information to RustcMetadata
manuelmauro f06a415
refactor: rename rustc module to binary
manuelmauro bdc50f4
Merge branch 'main' into manuel-add-more-components-to-healthcheck
manuelmauro 39f3864
Merge branch 'main' into manuel-add-more-components-to-healthcheck
manuelmauro 195aee4
refactor: remove redundant health status update
manuelmauro 4e14447
refactor: remove redundant health check update
manuelmauro 2acadca
fix: remove unused dependencies
manuelmauro d5d78fc
revert: revert formatting changes
manuelmauro f1d618c
Merge branch 'main' into manuel-add-more-components-to-healthcheck
Deniallugo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...lib/dal/.sqlx/query-3566423188a5d6bed7150f327d83613cd34138b59ef3b9271fd0bfdaddd086f8.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: The type of this field looks weird. If it's a duration, can it be converted to
std::time::Duration
? Alternatively, it may make sense to add a suffix (like_ms
) to the field name and convert it correspondingly.