Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: base token integration tests #2509

Merged
merged 94 commits into from
Oct 30, 2024
Merged

feat: base token integration tests #2509

merged 94 commits into from
Oct 30, 2024

Conversation

cytadela8
Copy link
Member

@cytadela8 cytadela8 commented Jul 26, 2024 •
edited
Loading

What ❔

  • Introduce 2 new tests for base token:
    • gas calculation
    • proper application of dynamic changes to base token ratio
  • Improve forced price client fluctuations implementation to limit difference between consecutive values.

Why ❔

  • We want better integration test coverage of custom base token

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

cytadela8 and others added 27 commits August 26, 2024 14:25
@cytadela8
Use forced price api client by default
87fc80f
@cytadela8
fix: smoothed ForcedPriceClient
0d8b455
@cytadela8
feat: Integration test gas price incl calculation
0ca2b5e
@cytadela8
fix: Fetch base ratio immediately on start
f15bade
@cytadela8
fix: enable all fees tests
ee7800b
@cytadela8
fix: increase alice wallet balance in fees.test.ts
6112552
@cytadela8
fix: style
e3e1356
@cytadela8
fix(tests): Kill with sigint
fd5fa8b
@cytadela8
tmp: remove randomness in base token price
7592dfd
@cytadela8
Try upgrade zksync-ethers to 6.11.0
a656770
@cytadela8
debug
ce0d00f
@cytadela8
Revert "Try upgrade zksync-ethers to 6.11.0"
73cebec 
This reverts commit 7e3213f.
@cytadela8
fix: properly kill server after fees test
ecf18a4
@cytadela8
Avoid gasEstimate in fees test
cb76faa
@cytadela8
fix: style
04b023a
@cytadela8
debug: more logs
79e691f
@cytadela8
debug: log addresses
8e554a2
@cytadela8
fix: increase test ETH per account due to large gas price test and re…
50fcd67 
…move transfer
@cytadela8
Revert "fix: increase test ETH per account due to large gas price tes…
baa5261 
…t and remove transfer"

This reverts commit 838b8a2.
@cytadela8
fix(test): Increase fees.test.ts alice account balance
c5213b1
@cytadela8
fix(test): Lower l1 gas price in expected gas price test
644c230
@cytadela8
fix(test): Lower l1 gas price in expected gas price test even more
0a9676b
@cytadela8
Revert "Avoid gasEstimate in fees test"
46d5414 
This reverts commit 90183b3.
@cytadela8
Revert "tmp: remove randomness in base token price"
c902dc2 
This reverts commit 6b330a4.
@cytadela8
fix: add validium compute overhead
93126b5
@ischasny @cytadela8
fix tests
358769d
@ischasny @cytadela8
reduce variation range
6c1f1af
ischasny
ischasny previously approved these changes Oct 21, 2024
View reviewed changes
@cytadela8 cytadela8 added this pull request to the merge queue Oct 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 29, 2024
@cytadela8 cytadela8 added this pull request to the merge queue Oct 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 30, 2024
@cytadela8 cytadela8 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 8db7e93 Oct 30, 2024
43 checks passed
@cytadela8 cytadela8 deleted the apu-base-token-integration branch October 30, 2024 15:43
This was referenced Oct 30, 2024
Open
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024
@zksync-era-bot
chore(main): release core 25.1.0 (#3162)
7fadc04 
🤖 I have created a release *beep* *boop*
---


##
[25.1.0](core-v25.0.0...core-v25.1.0)
(2024-11-04)


### Features

* add `block.timestamp` asserter for AA
([#3031](#3031))
([069d38d](069d38d))
* allow vm2 tracers to stop execution
([#3183](#3183))
([9dae839](9dae839))
* **api:** get rid of tx receipt root
([#3187](#3187))
([6c034f6](6c034f6))
* **api:** Integrate new VM into API server (no tracers)
([#3033](#3033))
([8e75d4b](8e75d4b))
* base token integration tests
([#2509](#2509))
([8db7e93](8db7e93))
* **consensus:** enabled syncing pregenesis blocks over p2p
([#3192](#3192))
([6adb224](6adb224))
* **da-clients:** add Celestia client
([#2983](#2983))
([d88b875](d88b875))
* **da-clients:** add EigenDA client
([#3155](#3155))
([5161eed](5161eed))
* gateway preparation
([#3006](#3006))
([16f2757](16f2757))
* Implement gas relay mode and inclusion data for data attestation
([#3070](#3070))
([561fc1b](561fc1b))
* **metadata-calculator:** Add debug endpoints for tree API
([#3167](#3167))
([3815252](3815252))
* **proof-data-handler:** add first processed batch option
([#3112](#3112))
([1eb69d4](1eb69d4))
* **proof-data-handler:** add tee_proof_generation_timeout_in_secs param
([#3128](#3128))
([f3724a7](f3724a7))
* **prover:** Add queue metric to report autoscaler view of the queue.
([#3206](#3206))
([2721396](2721396))
* **prover:** Add sending scale requests for Scaler targets
([#3194](#3194))
([767c5bc](767c5bc))
* **prover:** Add support for scaling WGs and compressor
([#3179](#3179))
([c41db9e](c41db9e))
* **vm:** Support EVM emulation in fast VM
([#3163](#3163))
([9ad1f0d](9ad1f0d))


### Bug Fixes

* **consensus:** better logging of errors
([#3170](#3170))
([a5028da](a5028da))
* **consensus:** made attestation controller non-critical
([#3180](#3180))
([6ee9f1f](6ee9f1f))
* **consensus:** payload encoding protected by protocol_version
([#3168](#3168))
([8089b78](8089b78))
* **da-clients:** add padding to the data within EigenDA blob
([#3203](#3203))
([8ae06b2](8ae06b2))
* **da-clients:** enable tls-roots feature for tonic
([#3201](#3201))
([42f177a](42f177a))
* extend allowed storage slots for validation as per EIP-7562
([#3166](#3166))
([c76da16](c76da16))
* **merkle-tree:** Fix tree truncation
([#3178](#3178))
([9654097](9654097))
* **tee_prover:** add prometheus pull listener
([#3169](#3169))
([1ffd22f](1ffd22f))
* update logging in cbt l1 behaviour
([#3149](#3149))
([d0f61b0](d0f61b0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@artmakh artmakh artmakh approved these changes

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@otani88 otani88 Awaiting requested review from otani88 otani88 is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

@popzxc popzxc Awaiting requested review from popzxc

@ischasny ischasny Awaiting requested review from ischasny

@Deniallugo Deniallugo Awaiting requested review from Deniallugo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cytadela8 @perekopskiy @Deniallugo @popzxc @artmakh @ischasny