Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom crates version suffix support #14

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

antonbaliasnikov
Copy link
Contributor

@antonbaliasnikov antonbaliasnikov commented Jan 21, 2025

What ❔

  • Add custom suffix support for the workspace version.
  • Add capability to update Cargo.lock for other workspaces

Why ❔

Sometimes it is required to add a suffix to the crates version. As release-please is unable to properly work with prereleases and support suffixes and fails to update only version part (it removes a part of the suffix with each update), the proposed solution is to update Cargo.toml workspace version separately just before Cargo.lock updates and commit changes together to the release PR.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@antonbaliasnikov antonbaliasnikov force-pushed the aba-custom-crates-suffix branch 3 times, most recently from d6a0414 to 98b8c0e Compare January 21, 2025 15:22
@antonbaliasnikov antonbaliasnikov marked this pull request as ready for review January 21, 2025 15:36
@antonbaliasnikov antonbaliasnikov force-pushed the aba-custom-crates-suffix branch from 98b8c0e to 0b2de8d Compare January 21, 2025 15:36
@antonbaliasnikov antonbaliasnikov changed the title feat: add custom creates suffix support feat: add custom crates suffix support Jan 21, 2025
@antonbaliasnikov antonbaliasnikov changed the title feat: add custom crates suffix support feat: add custom crates version suffix support Jan 21, 2025
@antonbaliasnikov antonbaliasnikov force-pushed the aba-custom-crates-suffix branch 3 times, most recently from 04272f2 to f4e436a Compare January 21, 2025 15:55
@antonbaliasnikov antonbaliasnikov merged commit 2cfce1a into main Jan 21, 2025
1 check passed
@antonbaliasnikov antonbaliasnikov deleted the aba-custom-crates-suffix branch January 21, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants