Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some methods operating on wrong near call #69

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

joonazan
Copy link
Contributor

@joonazan joonazan commented Sep 24, 2024

Targeting near calls in the tracer API was very buggy and the code for it was rather convoluted. Both issues are fixed and regression tests are added.

Also fixes an issue where setting the pc would always set the current pc instead of the pc of the targeted frame.

@joonazan joonazan requested a review from slowli September 24, 2024 14:29
@joonazan joonazan enabled auto-merge (squash) September 24, 2024 14:34
crates/vm2/src/tracing.rs Outdated Show resolved Hide resolved
@joonazan joonazan merged commit 9b36813 into master Sep 25, 2024
9 checks passed
@joonazan joonazan deleted the fix-near-call-api branch September 25, 2024 07:00
joonazan pushed a commit that referenced this pull request Sep 25, 2024
🤖 I have created a release *beep* *boop*
---


## [0.2.1](v0.2.0...v0.2.1)
(2024-09-25)


### Bug Fixes

* some methods operating on wrong near call
([#69](#69))
([9b36813](9b36813))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants