feat: Add EcPairing precompile #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrchatruc
requested review from
vladbochok and
StanislavBreadless
as code owners
| /// @param x The x coordinate of the point in Montgomery form. | ||
| /// @param y The y coordinate of the point in Montgomery form. | ||
| /// @return ret True if the point is on the curve, false otherwise. | ||
| function g1AffinePointIsOnCurve(x, y) -> ret { |
There was a problem hiding this comment.
probably mix of tabs/spaces, it looks weird in the github PR diff
There was a problem hiding this comment.
Fixed on this commit 99af881
mm-zk
reviewed
Apr 22, 2024
| @@ -3,120 +3,127 @@ | |||
| "contractName": "AccountCodeStorage", | |||
| "bytecodePath": "artifacts-zk/contracts-preprocessed/AccountCodeStorage.sol/AccountCodeStorage.json", | |||
| "sourceCodePath": "contracts-preprocessed/AccountCodeStorage.sol", | |||
| "bytecodeHash": "0x01000075e8397f3d02eddfe166a8324a2ac31a6da0db8eeebfa8739d3f31aad6", | |||
| "sourceCodeHash": "0xfbf66e830201c4b7fda14f0ddf28a53beb7fbb48a8406392bcfd0ef7ea9265c8" | |||
| "bytecodeHash": "0x01000081df25f20524a83dc78040b54bdd50e97de2381e220757f07a56a9dd8b", | |||
There was a problem hiding this comment.
why are there all these changes? did you use a different compiler version?
There was a problem hiding this comment.
It seems there was an issue in my environment, although the local setup (yarn sc build) is not working for me on this branch (i.e. dev), so it was hard for me to fix; something seems to be broken on the repo setup. I had to hardcode the path to my solc version 0.8.20 on the typescript code to get it to work properly.
The file is now fixed on commit ccae737 and only the new pairing hashes are added
|
The table below presents the gas usage reports for the
|
6 tasks
vladbochok
approved these changes
Apr 23, 2024
Co-authored-by: Stanislav Bezkorovainyi <[email protected]> Co-authored-by: Lyova Potyomkin <[email protected]> Co-authored-by: Javier Chatruc <[email protected]>
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this pull request
Apr 23, 2024
## What ❔ Add `EcPairing` precompile to the system contracts list. This is expected to be merged after the [PR](matter-labs/era-contracts#383) adding the `EcPairing` precompile implementation gets merged into `era-contracts`. The address of the precompile corresponds to the one used in Ethereum (`0x08`). Part of EVM-572 ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. - [ ] Linkcheck has been run via `zk linkcheck`. --------- Co-authored-by: Javier Chatruc <[email protected]>
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this pull request
Apr 24, 2024
## What ❔ Add `EcPairing` precompile to the system contracts list. This is expected to be merged after the [PR](matter-labs/era-contracts#383) adding the `EcPairing` precompile implementation gets merged into `era-contracts`. The address of the precompile corresponds to the one used in Ethereum (`0x08`). Part of EVM-572 ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. - [ ] Linkcheck has been run via `zk linkcheck`. --------- Co-authored-by: Javier Chatruc <[email protected]> Co-authored-by: Stanislav Bezkorovainyi <[email protected]>
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this pull request
Apr 24, 2024
## What ❔ Add `EcPairing` precompile to the system contracts list. This is expected to be merged after the [PR](matter-labs/era-contracts#383) adding the `EcPairing` precompile implementation gets merged into `era-contracts`. The address of the precompile corresponds to the one used in Ethereum (`0x08`). Part of EVM-572 ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. - [ ] Linkcheck has been run via `zk linkcheck`. --------- Co-authored-by: Javier Chatruc <[email protected]> Co-authored-by: Stanislav Bezkorovainyi <[email protected]>
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this pull request
Apr 24, 2024
## What ❔ Add `EcPairing` precompile to the system contracts list. This is expected to be merged after the [PR](matter-labs/era-contracts#383) adding the `EcPairing` precompile implementation gets merged into `era-contracts`. The address of the precompile corresponds to the one used in Ethereum (`0x08`). Part of EVM-572 ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`. - [ ] Linkcheck has been run via `zk linkcheck`. --------- Co-authored-by: Javier Chatruc <[email protected]> Co-authored-by: Stanislav Bezkorovainyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds the EcPairing precompile from https://github.com/lambdaclass/zksync_era_precompiles/, commit 4bdfebf831e21d58c5ba6945d4524763f1ef64d4.
Part of EVM-572
Why ❔
Checklist