Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OZ ZKChain: Governance Audit Fixes Combines #1044

Open
wants to merge 41 commits into
base: governance-fix-review
Choose a base branch
from
Open

feat: OZ ZKChain: Governance Audit Fixes Combines #1044

wants to merge 41 commits into from

Commits on Oct 10, 2024

  1. remove gas constant

    @StanislavBreadless
    StanislavBreadless committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c764e73 View commit details
    Browse the repository at this point in the history

  2. fix unit tests

    @StanislavBreadless
    StanislavBreadless committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3a2e242 View commit details
    Browse the repository at this point in the history

  3. separate function

    @StanislavBreadless
    StanislavBreadless committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1d2491a View commit details
    Browse the repository at this point in the history

  4. fix comments

    @StanislavBreadless
    StanislavBreadless committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f7e2eff View commit details
    Browse the repository at this point in the history

  5. add tests for the new methods

    @StanislavBreadless
    StanislavBreadless committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d5e7667 View commit details
    Browse the repository at this point in the history

  6. additional checks for restrictions

    @StanislavBreadless
    StanislavBreadless committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1c01590 View commit details
    Browse the repository at this point in the history

  7. gas optimization

    @StanislavBreadless
    StanislavBreadless committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5410fde View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Update l1-contracts/contracts/governance/restriction/RestrictionValid… 

    …ator.sol

Co-authored-by: Vlad Bochok <[email protected]>
    @StanislavBreadless @vladbochok
    StanislavBreadless and vladbochok authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1bdf736 View commit details
    Browse the repository at this point in the history

  2. Update l1-contracts/contracts/governance/PermanentRestriction.sol 

    Co-authored-by: Vlad Bochok <[email protected]>
    @StanislavBreadless @vladbochok
    StanislavBreadless and vladbochok authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    cacd00f View commit details
    Browse the repository at this point in the history

  3. Update l1-contracts/contracts/governance/PermanentRestriction.sol 

    Co-authored-by: Vlad Bochok <[email protected]>
    @StanislavBreadless @vladbochok
    StanislavBreadless and vladbochok authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7f3511b View commit details
    Browse the repository at this point in the history

  4. Update l1-contracts/contracts/governance/L2AdminFactory.sol 

    Co-authored-by: Vlad Bochok <[email protected]>
    @StanislavBreadless @vladbochok
    StanislavBreadless and vladbochok authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    57a3d97 View commit details
    Browse the repository at this point in the history

  5. Add ChainAdmin contract

    @vladbochok
    vladbochok committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    dfcb9cd View commit details
    Browse the repository at this point in the history

  6. Fix N-03

    @vladbochok
    vladbochok committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c832b06 View commit details
    Browse the repository at this point in the history

  7. Emit event

    @vladbochok
    vladbochok committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f954a58 View commit details
    Browse the repository at this point in the history

  8. Fix N-05

    @vladbochok
    vladbochok committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3a4f426 View commit details
    Browse the repository at this point in the history

  9. Fix N-06

    @vladbochok
    vladbochok committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7ce1e00 View commit details
    Browse the repository at this point in the history

  10. Fix N-07

    @vladbochok
    vladbochok committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    04268f3 View commit details
    Browse the repository at this point in the history

  11. review comments

    @StanislavBreadless
    StanislavBreadless committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d0c822a View commit details
    Browse the repository at this point in the history

  12. doc comment

    @StanislavBreadless
    StanislavBreadless committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a418fb0 View commit details
    Browse the repository at this point in the history

  13. Update l1-contracts/contracts/governance/L2AdminFactory.sol 

    Co-authored-by: Vlad Bochok <[email protected]>
    @StanislavBreadless @vladbochok
    StanislavBreadless and vladbochok authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    12618e8 View commit details
    Browse the repository at this point in the history

  14. fix review

    @StanislavBreadless
    StanislavBreadless committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0fb6ebf View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Apply suggestion

    @vladbochok
    vladbochok committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    af8a60e View commit details
    Browse the repository at this point in the history

  2. Update l1-contracts/contracts/governance/L2AdminFactory.sol 

    Co-authored-by: Vlad Bochok <[email protected]>
    @StanislavBreadless @vladbochok
    StanislavBreadless and vladbochok authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1aed805 View commit details
    Browse the repository at this point in the history

  3. Update l1-contracts/contracts/governance/L2AdminFactory.sol 

    Co-authored-by: Vlad Bochok <[email protected]>
    @StanislavBreadless @vladbochok
    StanislavBreadless and vladbochok authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7209d99 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. respond to comments

    @StanislavBreadless
    StanislavBreadless committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    bf9251a View commit details
    Browse the repository at this point in the history

  2. fix suggestion

    @StanislavBreadless
    StanislavBreadless committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    64cceff View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Merge remote-tracking branch 'origin/sb-governance-m01' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    210beef View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/sb-governance-m02' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    e9f969d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/sb-governance-l01' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2874526 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/sb-governance-l02' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    a264642 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/sb-governance-n01' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9093c05 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/vb-governance-n02' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f14c3e2 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/vb-governance-n03' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    cc2cd8b View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/vb-governance-n04' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    444cf6b View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/vb-governance-n05' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    befa74a View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/vb-governance-n06' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2430404 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'origin/vb-governance-n07' into ra/gover… 

    …nance-fix-review-merged-fixes
    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9bcd15b View commit details
    Browse the repository at this point in the history

  12. (fix): merge conflicts from all commits

    Raid Ateir committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    bf8e072 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. (fix): add clarifying comment

    Raid Ateir committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    59e0d42 View commit details
    Browse the repository at this point in the history

  2. (fix): codespell

    Raid Ateir committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7d28493 View commit details
    Browse the repository at this point in the history

  3. (fix): wrong function marked internal

    Raid Ateir committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    82fef7c View commit details
    Browse the repository at this point in the history