feat: implement anvil_zks_{prove,execute}Batch
#586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+10
to
+15
|
|
||
| #[method(name = "proveBatch")] | ||
| async fn prove_batch(&self, batch_number: L1BatchNumber) -> RpcResult<H256>; | ||
|
|
||
| #[method(name = "executeBatch")] | ||
| async fn execute_batch(&self, batch_number: L1BatchNumber) -> RpcResult<H256>; |
There was a problem hiding this comment.
Should we be documenting these API endpoints in https://github.com/matter-labs/anvil-zksync/blob/main/SUPPORTED_APIS.md?
Comment on lines
+499
to
+500
| // Batches are not being used when running in forking mode | ||
| batches: HashMap::from_iter([]), |
There was a problem hiding this comment.
Why would batches not be used during forking?
Comment on lines
+640
to
+646
| // Our version of contracts has system log and data availability verification disabled. | ||
| // Hence, we are free to create a zeroed out dummy header without any logs whatsoever. | ||
| let header = L1BatchHeader::new( | ||
| self.current_batch, | ||
| 0, | ||
| // We could use contract hashes that were actually used, but they might differ from what | ||
| // L1 expects due to impersonation |
There was a problem hiding this comment.
If a user checkouts different system contracts that has system log and data availability verification enabled will that be a problem? Just thinking about our own protocol devs usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Next part of #536
Introduces support for proving and executing on L1. Adds persistent batches to
Blockchainas we must submit batches with consistent root hash. So now L1 sidecar loads batch headers fromcorewhich is more realistic to what would usually happen and bring us one step closer to having proper system logs (we need to makeInMemoryNodepersist them in the resulting batch).Why ✋
L1-L2 communication