feat: add --show-outputs flag #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra-test-node into feat-add-show-outputs-flag
MexicanAce
reviewed
Mar 13, 2024
| @@ -218,6 +218,9 @@ struct Cli { | |||
| #[arg(long, default_value = "none")] | |||
| /// Show call debug information | |||
| show_calls: ShowCalls, | |||
| #[arg[long]] | |||
| /// Show call output | |||
| show_outputs: bool, | |||
There was a problem hiding this comment.
This is awesome, thank you!!
One thing we've done with the other feature flags, is to have them be configurable via API calls in the config_ namespace( example config_setResolveHashes). So if you forgot to enable Call Output when you start the in-memory node, you don't have to restart the node and potentially lose state.
I think we might want to do the same here, thoughts?
Here are some other config_ API examples: https://github.com/matter-labs/era-test-node/blob/main/SUPPORTED_APIS.md#config_setresolvehashes
There was a problem hiding this comment.
That makes sense, added the API calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Add
--show-outputsflag to be able to see the outputs of every callWhy ✋
The option to show the call outputs could be convenient while debugging(especially while debugging system calls, that was my use case for it) because it allows greater transparency.
Evidence 📷
How it looks in terminal:
