Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added detailed information on amount of pubdata per write #248

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Dec 19, 2023

What 💻

  • Display detailed information on how many pubdata bytes does each write cost
  • added "paid" option to --show-storage-logs to see only the writes that cost pubdata

Why ✋

  • The cost of pubdata is in many cases the highest cost related to the transaction
  • with boojum release, we use pubdata compression, so each slot might use between 6 and 64 bytes - so it is important for users to see how much they have to pay - and this would also be a good signal for them to see where they can save.

Evidence 📷

image

@mm-zk mm-zk requested a review from a team as a code owner December 19, 2023 12:06
@mm-zk mm-zk requested a review from MexicanAce December 19, 2023 12:07
src/node/in_memory.rs Outdated Show resolved Hide resolved
@mm-zk mm-zk requested a review from MexicanAce December 19, 2023 18:49
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit e91949f into main Dec 20, 2023
9 checks passed
@MexicanAce MexicanAce deleted the 1219_pubdata_count_only branch December 20, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants