Logical bug fix #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out the logical error was in my head. |
|
That's the worst ones to get;) glad toi figure it out.
…On Jun 26, 2017 9:00 PM, "Jalil F." ***@***.***> wrote:
Turns out the logical error was in my head.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXtfEMmkjEy_y0ZAbwTSPeRiAxX6Rqyks5sH__NgaJpZM4OFreh>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is broken in this line. ecrecover seems to return a single address, but the test requires the address be equal to the channelSender and the channelRecipient. By adding the
||, Alice or Bob can post... Alice or Bob's hash values, and the other party would then need to sign the hash value to release the funds.I asked about this here, and I'd love to hear your input. I first thought maybe I didn't understand ecrecover, but in the docs, it really does only return a single address unless I'm mistaken.