Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from fedidcg:main #23

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[pull] main from fedidcg:main #23

merged 1 commit into from
Aug 17, 2023

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 17, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

* Use generic names for the header and JS API

This removes "IDP" from the HTTP header and JS API names so that they are more
compatible with the is-logged-in API:
https://github.com/privacycg/is-logged-in

See also privacycg/is-logged-in#54

Open question:
Should the JS API use the exact name in the current is-logged-in
explainer (recordLoggedIn) or the more consistent name that this
PR uses (recordSignedIn)?

* grammar fixes
@pull pull bot added the ⤵️ pull label Aug 17, 2023
@pull pull bot merged commit 273ccb0 into mattdanielbrown:main Aug 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant