Wait until channel read completes before decoding packet. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when reading large amounts of data, this data may be read in multiple passes. we must wait until all data has been read before trying to decode a packet from this data.
as suggested by the documentation
|
Fixes #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading large(ish) amounts of data, it is possible this data is read in multiple passes.
This means that
channelReadcould be called multiple times in succession, each time receiving only a chunk of the full data.To prevent trying to decode partial data, we must postpone the packet decoding until the channel read operation completes, which is we should do this in
channelReadCompleteinstead.I have also inserted calls to forward operations to the next handler in the pipeline, as suggested by the documentation of the protocol functions.