Skip to content

Commit

Permalink
reorganisation of code
Browse files Browse the repository at this point in the history
  • Loading branch information
kt86 committed Dec 20, 2024
1 parent 1eac344 commit 9e65b09
Showing 1 changed file with 18 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ public double getDeliveryDuration() {
/**
* Do we really need the setter? We do have it in the builder.
* I do not see, why we should be able to update it, since most of the values are immutable.
* @deprecated Consider setting it using the Builder. This will maybe be removed and the field gets immutable..
* @deprecated Consider setting it using the Builder. This will maybe be removed and the field gets immutable.
* kturner, dec'24
*/
@Deprecated(since = "dec'24")
Expand All @@ -265,7 +265,7 @@ public void setPickupDuration(double pickupDuration) {
/**
* Do we really need the setter? We do have it in the builder.
* I do not see, why we should be able to update it, since most of the values are immutable.
* @deprecated Consider setting it using the Builder. This will maybe be removed and the field gets immutable..
* @deprecated Consider setting it using the Builder. This will maybe be removed and the field gets immutable.
* kturner, dec'24
*/
@Deprecated(since = "dec'24")
Expand Down Expand Up @@ -317,6 +317,7 @@ public int getSize() {
return getDemand();
}


/**
* @deprecated please inline and use {@link #getPickupLinkId()} instead
*/
Expand All @@ -325,14 +326,6 @@ public Id<Link> getFrom() {
return getPickupLinkId();
}

/**
* @deprecated please inline and use {@link #getDeliveryLinkId()} instead
*/
@Deprecated(since = "dec'24")
public Id<Link> getTo() {
return getDeliveryLinkId();
}

/**
* @deprecated please inline and use {@link #getPickupStartsTimeWindow()} instead
*/
Expand All @@ -341,13 +334,12 @@ public TimeWindow getPickupTimeWindow() {
return getPickupStartsTimeWindow();
}


/**
* @deprecated please inline and use {@link #getDeliveryStartsTimeWindow()} instead
* @deprecated please inline and use {@link #setPickupDuration(double)} instead
*/
@Deprecated(since = "dec'24")
public TimeWindow getDeliveryTimeWindow() {
return getDeliveryStartsTimeWindow();
public void setPickupServiceTime(double pickupDuration) {
setPickupDuration(pickupDuration);
}

/**
Expand All @@ -358,12 +350,21 @@ public double getPickupServiceTime() {
return getPickupDuration();
}


/**
* @deprecated please inline and use {@link #setPickupDuration(double)} instead
* @deprecated please inline and use {@link #getDeliveryLinkId()} instead
*/
@Deprecated(since = "dec'24")
public void setPickupServiceTime(double pickupDuration) {
setPickupDuration(pickupDuration);
public Id<Link> getTo() {
return getDeliveryLinkId();
}

/**
* @deprecated please inline and use {@link #getDeliveryStartsTimeWindow()} instead
*/
@Deprecated(since = "dec'24")
public TimeWindow getDeliveryTimeWindow() {
return getDeliveryStartsTimeWindow();
}

/**
Expand Down

0 comments on commit 9e65b09

Please sign in to comment.