refactor some cdc code - phase 1 #21656
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuPeng-SH
requested review from
fengttt,
zhangxu19830126,
daviszhen,
qingxinhome,
reusee and
ck89119
as code owners
ck89119
approved these changes
Apr 7, 2025
zhangxu19830126
approved these changes
Apr 9, 2025
fengttt
reviewed
Apr 16, 2025
| incrConfig string, | ||
| additionalConfigStr string, | ||
| ) string { | ||
| return fmt.Sprintf( |
There was a problem hiding this comment.
All these Sprintf based SQL construction are subject to SQL injection. I wonder if we can make it use param binding -- or even if not possible, values be systematically escaped here.
fengttt
reviewed
Apr 16, 2025
| // compositedUriInfo uri according to the format: mysql://root:[email protected]:6001 | ||
| // if valid, return true and extracted info | ||
| // !!!NOTE!!! | ||
| // user and password does not have the special character ( ':' '@' ) |
There was a problem hiding this comment.
Is this enforced somehow/somewhere? Otherwise seems to me, the only way is to encode/decode this with &XXX;
Or some better/smarter encode/decode scheme.
fengttt
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #21017
What this PR does / why we need it:
refactor some cdc code