Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if data["content"] is a dict before using it as a dict #362

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Check if data["content"] is a dict before using it as a dict #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0c39f3
Check if `data["content"]` is a dict before using it as a dict
c-cal Mar 8, 2024
5c23c88
Add newsfile
reivilibre Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/362.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug causing Sygnal to fail when processing notifications without a `content` dict, when those notifications were destined for GCM. Contributed by @c-cal.
2 changes: 1 addition & 1 deletion sygnal/gcmpushkin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ def _build_data(
data[attr] = data[attr][0:MAX_BYTES_PER_FIELD]

if api_version is APIVersion.V1:
if "content" in data:
if isinstance(data.get("content"), dict):
for attr, value in data["content"].items():
if not isinstance(value, str):
continue
Expand Down
Loading