Allow to configure if pushkey should be converted to hex before sending to APNs

[danbim]

I ran into the same problem as #301 and decided to instead make this configurable in Sygnal. Not sure if this is the right approach, happy for feedback and adopting to something else :)

Signed-off-by: Daniel Bimschas [email protected] / [email protected]

[reivilibre]

Happy with the idea of the change but just the option seems to be called the opposite of what it should be, if it's me being stupid then do say :)

[clokep]

Would you mind adding a newsfile?

[clokep]

@danbim Ah, sorry can you sign-off on your changes? Should be good to go if CI passes! 🎉

[danbim]

@clokep Haven't used this mechanism before. Should I rewrite history for this or is adding an empty commit with sign off sufficient?

[clokep]

@clokep Haven't used this mechanism before. Should I rewrite history for this or is adding an empty commit with sign off sufficient?

The easiest thing is usually to edit the PR description and manually add the text. Adding an empty commit to the PR is fine too.

[danbim]

@clokep Haven't used this mechanism before. Should I rewrite history for this or is adding an empty commit with sign off sufficient?

The easiest thing is usually to edit the PR description and manually add the text. Adding an empty commit to the PR is fine too.

Done. Added my private email as the commits were accidentally signed with my old employers email address 🙈

Comments handled

[clokep]

Thank you!

[danbim]

@clokep Out of egoistic personal interest to remove my patched fork to simplify my deployment: any plans when to have a new release including this MR? :)

[clokep]

Will need to ask @matrix-org/synapse-core id they have another release planned soon.

[danbim]

@clokep Do you maybe have any update on the question of a release? I have seen this project might move to element-hq due to the license change but so far I can't find it there. Cheers!

[clokep]

@danbim You'll need to ask the current team -- maybe @erikjohnston or @reivilibre would know.

[Half-Shot]

This appears to have now happened -> https://github.com/matrix-org/sygnal/releases/tag/v0.14.0