feat: MSC 4278 implementation #5014
Conversation
| // TODO: I think I should reset all the storage and perform a new local sync | ||
| // here but I don't know how |
There was a problem hiding this comment.
Not really sure what to do here
| // TODO: I think I should reset all the storage and perform a new local sync | ||
| // here but I don't know how |
There was a problem hiding this comment.
Not really sure what to do here
There was a problem hiding this comment.
I was actually looking at this recently and was surprised to see the store not getting updated when we set some account data. @poljar is there a way to tell the store that a piece of account data has been changed?
There was a problem hiding this comment.
Well the assumption is that a sync is running. Or maybe I'm misunderstanding what a local sync would be?
There was a problem hiding this comment.
I just looked at the the ignore_user and unignore_user function which has the exact same comment. So I assume this is a known issue maybe? I imagine that since the sync might take some time this means that if we change the value and immediately check the account data again, it won't be updated right?
And if so how long may it take to be update, are we talking about seconds or milliseconds?
Since this may affect how we design the UI.
There was a problem hiding this comment.
As long as a sync takes, you can subscribe to listen to account data events. There's actually a PR in flight to add exactly this to the bindings: #4994.
I suppose you'll have to subscribe to this anyways, in case the value gets updated on another device.
There was a problem hiding this comment.
nice this would be very useful!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5014 +/- ##
==========================================
- Coverage 85.86% 85.78% -0.08%
==========================================
Files 325 325
Lines 35853 35887 +34
==========================================
+ Hits 30785 30787 +2
- Misses 5068 5100 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Velin92
force-pushed
the
mauroromito/msc4278
branch
from
ad0b822 to
9feea1c
Compare
| // TODO: I think I should reset all the storage and perform a new local sync | ||
| // here but I don't know how |
There was a problem hiding this comment.
I was actually looking at this recently and was surprised to see the store not getting updated when we set some account data. @poljar is there a way to tell the store that a piece of account data has been changed?
Velin92
force-pushed
the
mauroromito/msc4278
branch
from
9feea1c to
4f4c52e
Compare
Velin92
force-pushed
the
mauroromito/msc4278
branch
from
4f4c52e to
60a2d20
Compare
This PR updates Ruma and implements new APIs to use the unstable MSC 4278.
This new global account data setting, will be used by clients to decide what policy to follow in display the media previews in the timeline, and the avatars in invite requests