-
Notifications
You must be signed in to change notification settings - Fork 287
crypto: Add a backup_version argument to group session backup methods #3253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
24ef7d4
to
3a7b8fc
Compare
1809e98
to
fffc900
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3253 +/- ##
==========================================
- Coverage 83.62% 83.62% -0.01%
==========================================
Files 238 238
Lines 24645 24649 +4
==========================================
+ Hits 20609 20612 +3
- Misses 4036 4037 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit strange to add an argument that no store uses, but I presume that you have an implementation and did double check that this indeed works as intended.
Left a nit for the changelog, looks good otherwise.
My plan is to check it works by implementing in the |
fffc900
to
1857332
Compare
1857332
to
f11aeaf
Compare
b1ebb72
to
a843125
Compare
I addressed the review comments and made a tiny refactor of the tests, so queuing to merge without additional review. |
As outlined in element-hq/element-web#26892 (comment) , pass in the backup version we mean when we call
inbound_group_sessions_for_backup
andmark_inbound_group_sessions_as_backed_up
. This will allow us to switch smoothly to a new backup version when the user asks to reset it, instead of modifying lots of records in our DB when this happens.Fixes https://github.com/element-hq/crypto-internal/issues/206