Skip to content

cleanup: move homeserver overriding to the SendRequest struct #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jan 9, 2024

Small simplification spotted while working on #3000.

@bnjbvr bnjbvr requested a review from a team as a code owner January 9, 2024 15:35
@bnjbvr bnjbvr requested review from Hywan and removed request for a team January 9, 2024 15:35
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve if and only if SS does not need another URL to run in our use cases.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13718c6) 83.46% compared to head (96cbd04) 83.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
- Coverage   83.46%   83.46%   -0.01%     
==========================================
  Files         222      222              
  Lines       23202    23200       -2     
==========================================
- Hits        19366    19364       -2     
  Misses       3836     3836              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr enabled auto-merge (rebase) January 9, 2024 15:49
@bnjbvr bnjbvr merged commit ae15595 into main Jan 9, 2024
@bnjbvr bnjbvr deleted the sliding-sync-homeserver-override branch January 9, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants