WIP: matrix-sdk-base: store timeline to StateStore #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm yeah, #141 should be closed in favor of this for sure, unless we want it around to refer to but #230 would probably be better for that. It might be worthwhile to look at #230 as closer to what it may end up being. This question #230 (comment) I'm still not sure how to answer. |
The TimelineSlice is a slice of the timeline of a room and contains the start and end of the slice.
Oh i didn't see #230. |
jsparber
force-pushed
the
messages-api
branch
2 times, most recently
from
86d0865 to
c0fc8b5
Compare
|
since this started with the wrong idea i will open a new MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #141 is stale for some time already. I took a shot at storing the timeline to the StateStore.
Obviously takes inspiration from #141
This still needs the implementation for the SledStore.