Skip to content

Add more JS/TS Framework support by adding the ability to choose the … #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danilobassi8
Copy link

@danilobassi8 danilobassi8 commented May 15, 2025

Add more JS/TS Framework support by adding the ability to choose the URL of wasm files.

This is related to the following issue #198

@danilobassi8 danilobassi8 requested a review from a team as a code owner May 15, 2025 12:45
@danilobassi8 danilobassi8 requested a review from andybalaam May 15, 2025 12:45
@danilobassi8 danilobassi8 force-pushed the fix-wasm-import-from-frameworks2 branch from d29ca39 to 2cb3d34 Compare May 15, 2025 12:48
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thanks fort the patch!

@Hywan
Copy link
Member

Hywan commented May 16, 2025

Error: index.cjs(72,26): error TS2322: Type 'string' is not assignable to type 'URL'.

Well, CI should be fixed :-].

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs a CI fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants