This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Remove debug logging from new room list #4972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#14408 Yes, all the issue references are wrong :(
t3chguy
approved these changes
Jul 14, 2020
|
@turt2live I wonder if it's useful for initial launch weeks to keep this logging in place, but just change it to be disabled by default? We can advise internal / community to flip the debug bool before sending a rageshake? Or if that seems like too much trouble for most people, also fine to remove as you've done here. |
|
@jryans in practice we've reached a point where the logs are mostly noise and the bugs are easily reproduced. This also doesn't remove the warnings or throws which often reveal a lot of the concerns. |
|
Fair enough, let's proceed then! |
jryans
pushed a commit
that referenced
this pull request
Jul 15, 2020
…launch/3-remove-debug" This reverts commit e1b34ac.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#14408
For element-hq/element-web#13635
Yes, all the issue references are wrong :(