This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Remove redundant scroll-margins and fix RoomTile wrongly scrolling #4952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
turt2live
reviewed
Jul 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the sticky headers are rendered outside of the main div the scroll-margins create redundant space and are not needed.
Fixes element-hq/element-web#14413
It is quite an ugly solution but the alternative is much much more complex scrolling code instead of being able to rely on
scrollIntoViewor the RoomTile updating the DOM properties of its parent with a similarly ugly hack.Tested on Firefox this produces no visual jumping/glitching/artifacting.
For element-hq/element-web#13635