This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add an option to disable room list logging, and improve logging #4944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For element-hq/element-web#14035 **This option is not recommended as it completely obliterates all chances of being able to support someone with a broken room list. It is intended for specific testing scenarios only.**
jryans
approved these changes
Jul 10, 2020
| @@ -331,26 +333,13 @@ export class Algorithm extends EventEmitter { | |||
| this.emit(LIST_UPDATED_EVENT); | |||
| } | |||
|
|
|||
| // TODO: Remove or use. | |||
| protected addPossiblyFilteredRoomsToTag(tagId: TagID, added: Room[]): void { | |||
There was a problem hiding this comment.
I guess this is no longer used...?
There was a problem hiding this comment.
It was never used, and I kept running into the comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#14035
For element-hq/element-web#13635
Caution
This option is not recommended as it completely obliterates all chances of being able to support someone with a broken room list. It is intended for specific testing scenarios only.
If you disable logging and encounter a bug, all bets are off on support.