This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Support prioritized room list filters #4737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix an issue where when using both the community filter panel and the search box it's an AND rather than further refining the results. This makes the search box further refine the community filter panel results.
jryans
approved these changes
Jun 9, 2020
| @@ -45,3 +45,63 @@ export function arrayDiff<T>(a: T[], b: T[]): { added: T[], removed: T[] } { | |||
| removed: a.filter(i => !b.includes(i)), | |||
| }; | |||
| } | |||
|
|
|||
| /** | |||
| * Helper functions to perform LINQ-like queries on arrays. | |||
There was a problem hiding this comment.
I see you're slowly implementing every C# / .NET Framework feature... 😜
There was a problem hiding this comment.
I really wanted groupBy
| /** | ||
| * Helper functions to perform LINQ-like queries on arrays. | ||
| */ | ||
| export class ArrayUtil<T> { |
There was a problem hiding this comment.
Util sounds like a module of static functions rather than a class to me... Not sure what to suggest at the moment though.
There was a problem hiding this comment.
Possibly LINQArray or Array2 to fully embrace .net bad practices. Or dump these on the Array prototype and forget that they're custom to the project
There was a problem hiding this comment.
Yikes. 😨 Let's just leave it as-is for now, can change if we're inspired later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#13635
This is to fix an issue where when using both the community filter panel and the search box it's an AND rather than further refining the results.
This makes the search box further refine the community filter panel results.
Screenshot proof (ignore the ugly CSS - that's not important here):
