Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Remove room key history sharing #12618

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Remove room key history sharing #12618

merged 2 commits into from
Jun 14, 2024

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Jun 14, 2024

The Rust crypto implementation doesn't implement key history sharing, and it causes errors in the logs. Since the Rust implementation is the default implementation, and all users will soon be migrated, remove key history sharing.

Also fixes element-hq/element-web#27150

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@uhoreg uhoreg requested a review from a team as a code owner June 14, 2024 01:10
@uhoreg uhoreg requested review from dbkr and t3chguy June 14, 2024 01:10
@uhoreg uhoreg added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 14, 2024
@uhoreg uhoreg added this pull request to the merge queue Jun 14, 2024
Merged via the queue into matrix-org:develop with commit 6fc9d76 Jun 14, 2024
31 checks passed
@uhoreg uhoreg deleted the remove_key_history_sharing branch June 14, 2024 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EW incorrectly claims "Invited people will be able to read old messages"
2 participants