MatrixRTC: Refactor | Introduce a new Encryption manager (used with experimental to device transport) #4799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fixup: bad do not commit
BillCarsonFr
force-pushed
the
valere/rtc/simple_encryption_manager
branch
from
73f738b to
3af1d3e
Compare
BillCarsonFr
force-pushed
the
valere/rtc/simple_encryption_manager
branch
from
3af1d3e to
b19c7a6
Compare
toger5
requested changes
Apr 15, 2025
Comment on lines
84
to
87
| public getEncryptionKeys(): Map<string, Array<{ key: Uint8Array; timestamp: number }>> { | ||
| // This is deprecated should be ignored. Only use by tests? | ||
| return new Map(); | ||
| } |
There was a problem hiding this comment.
The deprecation could already be added to IEncryptionManager (@deprecated)
33 tasks
richvdh
reviewed
Jul 3, 2025
| import { type CallMembership } from "./CallMembership.ts"; | ||
| import { decodeBase64, encodeBase64 } from "../base64.ts"; | ||
| import { type IKeyTransport, type KeyTransportEventListener, KeyTransportEvents } from "./IKeyTransport.ts"; | ||
| import { logger as rootLogger, type Logger } from "../logger.ts"; |
There was a problem hiding this comment.
please don't use logger.logger in new code: we should be threading the correct logger through from the parent MatrixClient.
toger5
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Did a sync (call) review session.
Open todos:
- solve
reemission(possible missing keys) situation- either by adding a stop gap key buffer to the new encryption manager
- or by forcing to allocate + subscribe on
joinRoomSession(passing the matrixKeyProvider (as a keySink interface) tojoinRoomSession
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new simplified EncryptionManager that will rotate the key for any membership change (join or leave or same)
There is no specific experimental flag to use it, it will use it for to device transport
Checklist
public/exportedsymbols have accurate TSDoc documentation.