Skip to content

MatrixRTC: Introduce key transport abstraction as prep work for to-device encryption #4773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 7, 2025
Merged

MatrixRTC: Introduce key transport abstraction as prep work for to-device encryption #4773

merged 15 commits into from
Apr 7, 2025

Conversation

BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Apr 1, 2025 •
edited by toger5
Loading

Preparation work for element-hq/element-call#3155 part of EPIC E2EE: Send media keys via to_device message

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@BillCarsonFr BillCarsonFr force-pushed the valere/matrix_rtc_key_transport branch from f3e0ab8 to af828c6 Compare April 1, 2025 10:06
@BillCarsonFr BillCarsonFr added the T-Task Tasks for the team like planning label Apr 1, 2025
@BillCarsonFr BillCarsonFr marked this pull request as ready for review April 1, 2025 10:21
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner April 1, 2025 10:21
@BillCarsonFr BillCarsonFr requested a review from toger5 April 1, 2025 10:21
toger5
toger5 reviewed Apr 1, 2025
View reviewed changes
Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the transport abstraction very much. It gives me confidence this will not get too stressful/confusing!

The one bit i did not fully grasp was: receiveRoomEvent. See comments.

@toger5 toger5 force-pushed the valere/matrix_rtc_key_transport branch 2 times, most recently from 44bfc63 to d92d751 Compare April 2, 2025 19:38
@toger5 toger5 mentioned this pull request Apr 3, 2025
Open
46 tasks
@toger5 toger5 changed the title MatrixRTC | Refactoring introduce a transport abstraction as prep work for to device transport MatrixRTC: Introduce key transport abstraction as prep work for to device transport Apr 3, 2025
@toger5 toger5 changed the title MatrixRTC: Introduce key transport abstraction as prep work for to device transport MatrixRTC: Introduce key transport abstraction as prep work for to-device transport Apr 3, 2025
@toger5 toger5 changed the title MatrixRTC: Introduce key transport abstraction as prep work for to-device transport MatrixRTC: Introduce key transport abstraction as prep work for to-device encryption Apr 3, 2025
@toger5 toger5 force-pushed the valere/matrix_rtc_key_transport branch from 538ad63 to bd6dda1 Compare April 3, 2025 13:18
@toger5 toger5 added this pull request to the merge queue Apr 7, 2025
Merged via the queue into develop with commit ba71235 Apr 7, 2025
30 checks passed
@toger5 toger5 deleted the valere/matrix_rtc_key_transport branch April 7, 2025 08:50
@dbkr dbkr mentioned this pull request Apr 9, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toger5 toger5 toger5 approved these changes

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillCarsonFr @toger5