Stub out the rust crypto implementation for browserify #3187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting all this stuff on the commandline is unweildy.
|
gah, this breaks webpack as well |
t3chguy
reviewed
Mar 2, 2023
richvdh
commented
Mar 2, 2023
Comment on lines
+156
to
+163
| "babelify", | ||
| { | ||
| "sourceMaps": "inline", | ||
| "presets": [ | ||
| "@babel/preset-env", | ||
| "@babel/preset-typescript" | ||
| ] | ||
| } |
There was a problem hiding this comment.
moving this here wasn't a requirement, but the commandline was getting increasingly unwieldy.
|
(Feel free to bypass sonar here) |
Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3182.
Even this took me an annoyingly long time to figure out. We really need to figure out if browserify is important to us.
This change is marked as an internal change (Task), so will not be included in the changelog.