Begin factoring out a CryptoBackend interface #2955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/element-r/crypto_backend
branch
from
6b58448 to
c63c1d3
Compare
richvdh
force-pushed
the
rav/element-r/crypto_backend
branch
2 times, most recently
from
c849533 to
8793f35
Compare
dbkr
approved these changes
Dec 12, 2022
richvdh
force-pushed
the
rav/element-r/crypto_backend
branch
from
dc6e7e6 to
666da93
Compare
richvdh
force-pushed
the
rav/element-r/crypto_backend
branch
from
666da93 to
a2bf9c0
Compare
|
I've rebased this on develop now that #2958 has merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#21972. Eventually I want to replace the whole of the current
Cryptoimplementation with an alternative implementation, but in order to get from here to there, I'm factoring out a common interface which will be implemented by both implementations.I'm also determined to fix the problem where the innards of the crypto implementation are exposed to applications via the
MatrixClient.cryptoproperty.It's not (yet) entirely clear what shape this interface should be, so I'm going with a minimal approach and adding things as we know we need them. This means that we need to keep the old
client.cryptoproperty around as well as a newclient.cryptoBackendproperty. Eventuallyclient.cryptowill go away, but that will be a breaking change in the js-sdk.Currently based on #2958This change is marked as an internal change (Task), so will not be included in the changelog.