Skip to content

Commit

Permalink
test(crypto): fix documentations and removed unused expect
Browse files Browse the repository at this point in the history
  • Loading branch information
florianduros committed Feb 4, 2025
1 parent 004a3b0 commit 8678df7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion spec/integ/crypto/crypto.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2318,7 +2318,7 @@ describe("crypto", () => {
// For legacy crypto, these tests only work properly with a proper (indexeddb-based) CryptoStore, so
// rather than using the existing `aliceClient`, create a new client. Once we drop legacy crypto, we can
// just use `aliceClient` here.
// XXX: Even with the rust-crypto, we need to create to a new client. The tests fail with a timeout error.
// XXX: Even with the rust-crypto, we need to create a new client. The tests fail with a timeout error.
client1 = await makeNewClient(homeserverurl, userId, "client1");
await client1.startClient({});
});
Expand Down
6 changes: 1 addition & 5 deletions spec/integ/crypto/verification.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -509,16 +509,12 @@ describe("verification", () => {
reciprocateQRCodeCallbacks.confirm();
await sendToDevicePromise;

// Rust crypto, on the other hand, waits for the 'done' to arrive from the other side.
// Rust crypto waits for the 'done' to arrive from the other side.
if (request.phase === VerificationPhase.Done) {
const userVerificationStatus = await aliceClient.getCrypto()!.getUserVerificationStatus(TEST_USER_ID);
// eslint-disable-next-line jest/no-conditional-expect
expect(userVerificationStatus.isCrossSigningVerified()).toBeTruthy();
await verificationPromise;
} else {
// rust crypto: still in flight
// eslint-disable-next-line jest/no-conditional-expect
expect(request.phase).toEqual(VerificationPhase.Started);
}

// the dummy device replies with its own 'done'
Expand Down

0 comments on commit 8678df7

Please sign in to comment.