Helm chart - CI - Fix using malformed output parameter syntax, make a…

…ppVersion substitution apply in place

Signed-off-by: Rhea Danzey <[email protected]>

.github/workflows/helm.yml

@@ -33,13 +33,13 @@ jobs:
       - name: "Get app version from package.json"
         id: get_hookshot_version
         run: |
-          echo "::set-output hookshot_version=$(cat package.json | yq .version)" >> "$GITHUB_OUTPUT"
+          echo "hookshot_version=$(cat package.json | yq .version)" >> "$GITHUB_OUTPUT"
 
       - name: Set chart appVersion to current package.json version
         uses: mikefarah/[email protected]
         with:
           cmd: |
-            yq '.appVersion="${{steps.get_hookshot_version.outputs.hookshot_version}}"' helm/hookshot/Chart.yaml
+            yq -i '.appVersion="${{steps.get_hookshot_version.outputs.hookshot_version}}"' helm/hookshot/Chart.yaml
     
       - name: Set values hookshot config to current config.sample.yml contents
         uses: mikefarah/[email protected]