Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate MediaProxy to bridge authenticated Matrix media (MSC3916) #365

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

tadzik
Copy link
Contributor

@tadzik tadzik commented May 29, 2024

Needs docs and stuff, depends on matrix-org/matrix-appservice-bridge#444

@tadzik tadzik changed the title Integrate MediaProxy to bridge authenticated Matrix media (MSC3910) Integrate MediaProxy to bridge authenticated Matrix media (MSC3916) May 29, 2024
@tadzik tadzik force-pushed the tadzik/media-proxy branch from 52271b9 to f9c1bb9 Compare September 2, 2024 08:30
@tadzik tadzik marked this pull request as ready for review September 2, 2024 08:31
@tadzik tadzik requested a review from a team as a code owner September 2, 2024 08:31
Copy link
Collaborator

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd like the changelog to explain a little bit more about what the admin has to do for the upgrade to work?

@@ -0,0 +1 @@
Use MediaProxy to serve authenticated Matrix media.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we describe this in a little more detail? Does the admin need to perform any actions here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will include a longer explanation in the release notes

@tadzik tadzik force-pushed the tadzik/media-proxy branch from c2ce719 to e1d35aa Compare September 2, 2024 12:44
@tadzik tadzik merged commit 830084c into matrix-org:develop Sep 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants