This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Allow reactivating users on the homeserver #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
6c0effd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6b3c2a7a.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-user-reactivation.matrix-authentication-service-docs.pages.dev |
This was referenced Jul 12, 2024
reivilibre
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
the only thing to comment on, is I wish we could make it clearer that unlock implies reactivation.
This gets super confusing given Synapse's own notion of user locks, user deactivations and user suspensions.
It'd be really good to straighten this out for the clarity of our code, interface and documentation.
Currently, I don't think I'd enjoy being a user of these features in combination because it doesn't make sense if you don't already know all the aspects.
However I am struggling to think of anything concrete to suggest...
|
I agree with you on this. I opened an issue to track this: #2978 |
sandhose
force-pushed
the
quenting/user-reactivation
branch
from
3f30498 to
6c0effd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2101
Fixes #2375