Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OPTIONS method on MSC3916 endpoints available without auth #3431

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Make OPTIONS method on MSC3916 endpoints available without auth #3431

merged 1 commit into from
Sep 22, 2024

Commits on Sep 20, 2024

  1. Make OPTIONS method on MSC3916 endpoints available without authentica… 

    …tion.

OPTIONS method is usually sent by browser in preflight requests,
most of the time we cannot control preflight request to add auth header.

Synapse will return a 204 response directly without authentication for
those OPTIONS method.

According to firefox's documentation, both 200 and 204 are acceptable
so I think there is no need to change handler in dendrite.

This closes #3424

No need to add a test because this is just a fix and I have tested on my
Cinny Web client personally.

Signed-off-by: arenekosreal <[email protected]>
    @arenekosreal
    arenekosreal committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    29028d7 View commit details
    Browse the repository at this point in the history