Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

More rows.Close() and rows.Err() #3262

Merged
merged 3 commits into from
Nov 9, 2023
Merged

More rows.Close() and rows.Err() #3262

merged 3 commits into from
Nov 9, 2023

Conversation

S7evinK
Copy link
Contributor

@S7evinK S7evinK commented Nov 8, 2023

Looks like we missed some rows.Close()

Even though rows.Err() is mostly not necessary, we should be more consistent in the DB layer.

@S7evinK S7evinK added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Nov 8, 2023
@S7evinK S7evinK requested a review from a team as a code owner November 8, 2023 16:39
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (ee73a90) 65.51% compared to head (434441d) 65.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3262      +/-   ##
==========================================
- Coverage   65.51%   65.49%   -0.02%     
==========================================
  Files         507      507              
  Lines       57217    57263      +46     
==========================================
+ Hits        37484    37507      +23     
- Misses      15892    15909      +17     
- Partials     3841     3847       +6     
Flag Coverage Δ
unittests 49.48% <72.91%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
federationapi/storage/postgres/queue_json_table.go 70.00% <100.00%> (ø)
...erationapi/storage/postgres/relay_servers_table.go 74.46% <100.00%> (ø)
...ederationapi/storage/sqlite3/joined_hosts_table.go 64.13% <100.00%> (ø)
federationapi/storage/sqlite3/queue_json_table.go 65.00% <100.00%> (ø)
...derationapi/storage/sqlite3/relay_servers_table.go 73.21% <100.00%> (ø)
...elayapi/storage/postgres/relay_queue_json_table.go 70.00% <100.00%> (ø)
relayapi/storage/sqlite3/relay_queue_json_table.go 65.00% <100.00%> (ø)
roomserver/storage/postgres/membership_table.go 79.70% <100.00%> (ø)
roomserver/storage/postgres/rooms_table.go 85.00% <100.00%> (ø)
...oomserver/storage/postgres/user_room_keys_table.go 82.71% <100.00%> (+0.43%) ⬆️
... and 40 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@S7evinK S7evinK changed the title More rows.Close() More rows.Close() and rows.Err() Nov 8, 2023
@S7evinK S7evinK merged commit 699f5ca into main Nov 9, 2023
16 of 20 checks passed
@S7evinK S7evinK deleted the s7evink/close-rows branch November 9, 2023 07:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants