Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

chore(helm): use empty/nil storageClass for helm-docs #3245

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

wrenix
Copy link
Contributor

@wrenix wrenix commented Oct 25, 2023

i believe that nil would be false in the if :

storageClass:

is still handled correct.


In past ( #3191 ), will have the problem with an empty string "":

storageClass: ""

do you take another look @S7evinK ?

@wrenix wrenix requested a review from a team as a code owner October 25, 2023 18:04
@wrenix wrenix force-pushed the patch-1 branch 2 times, most recently from 251bc87 to cf2e0eb Compare October 25, 2023 18:09
Copy link
Contributor

@S7evinK S7evinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@S7evinK S7evinK merged commit 4452833 into matrix-org:main Feb 29, 2024
2 checks passed
@wrenix wrenix deleted the patch-1 branch February 29, 2024 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants